Reject duplicate venue signers in create_venue and update_venue_signers#1915
Open
Reject duplicate venue signers in create_venue and update_venue_signers#1915
create_venue and update_venue_signers#1915Conversation
| pub fn create_venue( | ||
| origin: OriginFor<T>, | ||
| details: VenueDetails, | ||
| signers: Vec<T::AccountId>, |
Contributor
There was a problem hiding this comment.
We can change this to use a BtreeSet instead. The same for update_venue_signers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog
modified external API
create_venueandupdate_venue_signersother
DuplicateSigners